Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

[GKE] allow setting svc spec.loadBalancerIP for GKE reserved/static IPs #296

Merged
merged 1 commit into from
Jan 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions deploy/helm/kubecf/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ spec:
{{- if $service.clusterIP }}
clusterIP: {{ $service.clusterIP | quote }}
{{- end }}
{{- if $service.loadBalancerIP }}
loadBalancerIP: {{ $service.loadBalancerIP | quote }}
{{- end }}
{{- end }}
---
{{- with $service := index .Values.services "ssh-proxy" }}
Expand Down Expand Up @@ -166,6 +169,9 @@ spec:
{{- if $service.clusterIP }}
clusterIP: {{ $service.clusterIP | quote }}
{{- end }}
{{- if $service.loadBalancerIP }}
loadBalancerIP: {{ $service.loadBalancerIP | quote }}
{{- end }}
{{- end }}
---
{{- with $service := index .Values.services "tcp-router" }}
Expand Down Expand Up @@ -201,5 +207,8 @@ spec:
{{- if $service.clusterIP }}
clusterIP: {{ $service.clusterIP | quote }}
{{- end }}
{{- if $service.loadBalancerIP }}
loadBalancerIP: {{ $service.loadBalancerIP | quote }}
{{- end }}
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion deploy/helm/kubecf/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ kube:
# The storage class to be used for the instance groups that need it (e.g. bits, database and
# singleton-blobstore). If it's not set, the default storage class will be used.
storage_class: ~
# The service_cluster_ip_range and pos_cluster_ip_range are used by the internal security group
# The service_cluster_ip_range and pod_cluster_ip_range are used by the internal security group
f0rmiga marked this conversation as resolved.
Show resolved Hide resolved
# definition to allow apps to communicate with internal service brokers (e.g. credhub).
# service_cluster_ip_range can be fetched with the following command, assuming that the API
# server started with the `--service-cluster-ip-range` flag:
Expand Down