This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0rmiga
force-pushed
the
f0rmiga/rotate-cc-database-key
branch
from
January 6, 2020 19:55
cad8842
to
7a7c43f
Compare
mook-as
suggested changes
Jan 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally fine, just some fairly trivial comments.
With the prefix, the secrets are easily identifiable in the system.
mook-as
previously approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
7 tasks
bikramnehra
pushed a commit
that referenced
this pull request
Apr 21, 2020
bikramnehra
pushed a commit
that referenced
this pull request
Apr 21, 2020
CCDB encryption key rotation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
rotate-cc-database-key
errand with a mechanism for rotating the CCDB encryption key.Resolves #203.
Motivation and Context
CF allows rotating the CCDB encryption key. This PR introduces a mechanism for doing it with kubecf using Helm.
How Has This Been Tested?
rotate-cc-database-key
errand as instructed in the documentation introduced in this very same PR.Types of changes
Checklist: