Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

fix: loggregator DNS spam #365

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

f0rmiga
Copy link
Member

@f0rmiga f0rmiga commented Jan 27, 2020

Description

This fixes the loggregator DNS spam by rolling the release version back from 106 to 105. Also, refactors the release versioning ops-files for easier maintainability.

Motivation and Context

As noted by many people, the newest loggregator release has an issue related to too many DNS requests. E.g. cloudfoundry/loggregator-release#401.

How Has This Been Tested?

Deployed kubecf with the changes including Eirini and app-autoscaler. Then, I checked that the DNS was not being spammed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has security implications.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Thulio Ferraz Assis added 2 commits January 27, 2020 13:55
Centralized all release management into a single file for easier
maintainability.
It fixes the loggregator spam to the DNS server.
@f0rmiga f0rmiga added this to the 0.2.0 milestone Jan 27, 2020
@f0rmiga f0rmiga requested a review from mook-as January 27, 2020 22:17
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable; 👍 assuming CI is okay with it.

@f0rmiga f0rmiga merged commit 666ad8e into master Jan 28, 2020
@f0rmiga f0rmiga deleted the f0rmiga/rollback-loggregator-release branch January 28, 2020 00:07
bikramnehra pushed a commit that referenced this pull request Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants