This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Pass resource kind to versioned secret store when creating secrets #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
reviewed
Sep 25, 2020
| secret, err := env.GetSecret(env.Namespace, "desired-manifest-v1") | ||
| Expect(err).NotTo(HaveOccurred(), "error getting new desired manifest") | ||
| ownerReference := secret.GetOwnerReferences()[0] | ||
| Expect(ownerReference.Kind).To(Equal(bdv1.BOSHDeploymentResourceKind)) |
mudler
approved these changes
Sep 25, 2020
rohitsakala
force-pushed
the
rohit/bugfix
branch
4 times, most recently
from
0e3727a to
349f594
Compare
rohitsakala
force-pushed
the
rohit/bugfix
branch
from
349f594 to
d2f1d3e
Compare
manno
changed the title
manno
changed the title
manno
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#174949288
Depends on
cloudfoundry-incubator/quarks-job#124
cloudfoundry-incubator/quarks-utils#93