fix(apiserver): Check that app is bound on API routes #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvestre
added
allow-acceptance-tests
silvestre
force-pushed
the
clean-up-routes
branch
from
d409e2e
to
a0dcecb
Compare
# Issue It was possible to get information for a currently unbound app from the API server # Fix Check if the app is currently bound to the service on all routes.
silvestre
force-pushed
the
clean-up-routes
branch
from
a0dcecb
to
630d7e3
Compare
|
silvestre
changed the title
joergdw
approved these changes
Sep 27, 2024
asalan316
approved these changes
Sep 27, 2024
asalan316
added
allow-acceptance-tests
|
Somehow acceptance tests were skipped. I re-enabled them. May be if was due to the sequence of labels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
It was possible to get information for a currently unbound app from the
API server
Fix
Check if the app is currently bound to the service on all routes.