Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding binding_db to external-db.yml ops file #3302

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Oct 30, 2024

The v14.4.0 release of autoscaler introduces a db named binding_db, if you are using an external db, like RDS, and the ops file in operations/external-db.yml the templating errors out during deployment with:

Task 628502 | 15:28:11 | Error: Unable to render instance groups for deployment. Errors are:
  - Unable to render jobs for instance group 'metricsforwarder'. Errors are:
    - Unable to render templates for job 'metricsforwarder'. Errors are:
      - Error filling in template 'metricsforwarder.yml.erb' (line 9: Can't find property '["autoscaler.binding_db.port"]')

By adding binding_db to the external-db.yml ops file, there is no longer a bosh templating error when not using the built in postgres instance.

Copy link

sonarcloud bot commented Oct 30, 2024

@asalan316 asalan316 added the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Oct 31, 2024
@asalan316 asalan316 self-assigned this Oct 31, 2024
@asalan316
Copy link
Contributor

Hi @cweibel , thanks for your contribution.

Unfortunately, the acceptance test are not triggering. Probably, because that they are not configured to accept contribution from the fork branches.

But I have created a PR#3305 to validate it.

If GHA passes, I will merge the PR.

@asalan316 asalan316 merged commit 6310aab into cloudfoundry:main Nov 4, 2024
27 of 41 checks passed
@asalan316 asalan316 added the bug label Nov 4, 2024
@asalan316
Copy link
Contributor

@cweibel The fix should be in release 14.4.1

Thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. approved bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants