Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove registry support #698

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Remove registry support #698

merged 1 commit into from
Sep 10, 2024

Conversation

jpalermo
Copy link
Member

@jpalermo jpalermo commented Sep 8, 2024

This removes older registry support. This has been deprecated since at least 2019 and no stemcells published for the last 5+ years support using the registry.

It also removes some older unused dev files.

All unit, integration and bats pass on the branch currently.

@jpalermo jpalermo requested review from a team, mvach and a-hassanin and removed request for a team September 8, 2024 00:48
@cunnie cunnie self-requested a review September 8, 2024 02:40
Copy link
Member

@cunnie cunnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe you were finally able to do this — hurrah! Thanks, Joseph.

Copy link
Member

@aramprice aramprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, added comments on a couple of changes that seemed 🤔

@jpalermo jpalermo merged commit 5960fd1 into master Sep 10, 2024
1 check passed
@jpalermo jpalermo deleted the pr-remove-registry branch September 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants