Interpolate the manifest before deploying #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- OpsFiles can modify stemcells and releases (e.g windows-cell.yml https://github.com/cloudfoundry/cf-deployment/blob/master/operations/windows-cell.yml) this will allow the stemcells to be consumed properly [#148348965] Fix #14 Signed-off-by: Amin Jamali <ajamali@pivotal.io>
|
Hey mdelillo! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
Thanks for submitting the PR! Still reading through the PR. Wanted to ask why you needed to add the skip-export flag? The resource should only attempt to export releases if you specify the |
Signed-off-by: Amin Jamali <ajamali@pivotal.io>
|
@drich10 We have revised the PR. We removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpsFiles can modify stemcells and releases (e.g windows-cell.yml
https://github.com/cloudfoundry/cf-deployment/blob/master/operations/windows-cell.yml)
this will allow the stemcells to be consumed properly
We also added a
skip_exportoption to the get. If multiple stemcells are present (i.e. linux and windows), then the get will fail because bosh does not support exporting releases with multiple stemcells.Fix #14
Signed-off-by: Amin Jamali ajamali@pivotal.io