Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azure-storage-cli to the stemcells #295

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add azure-storage-cli to the stemcells #295

merged 2 commits into from
Aug 3, 2023

Conversation

ten4o
Copy link
Contributor

@ten4o ten4o commented Jul 20, 2023 •
edited
Loading

Add blobstore client for Azure aka azure-storage-cli binary to the stemcells.

Related PRs

@ten4o ten4o changed the title Add azure-storage-cli to jammy stemcell Add azure-storage-cli to the stemcells Jul 20, 2023
Malsourie
Malsourie approved these changes Jul 20, 2023
View reviewed changes
Copy link

@Malsourie Malsourie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For integrating azure-storage-cli into stemcell-builder, LGTM.
In the future, the three assets files .sha256sum, .url and .version should be maintained by bosh-stemcells-ci.

Malsourie
Malsourie suggested changes Jul 20, 2023
View reviewed changes
bosh-stemcell/spec/stemcells/go_agent_spec.rb Outdated
@@ -2,7 +2,7 @@

describe 'Stemcell with Go Agent', stemcell_image: true do
describe 'installed by bosh_go_agent' do
%w(bosh-agent bosh-agent-rc bosh-blobstore-dav bosh-blobstore-gcs bosh-blobstore-s3).each do |binary|
%w(bosh-agent bosh-agent-rc bosh-blobstore-dav bosh-blobstore-gcs bosh-blobstore-s3 bosh-blobstore-az).each do |binary|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the package name to bosh-blobstore-azure-storage corresponding to the definition in azure-storage-cli repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

stemcell_builder/stages/blobstore_clis/config.sh Outdated
@@ -11,7 +11,7 @@ persist_value downloaded_cli_dir
rm -rf "${downloaded_cli_dir}"
mkdir -p "${downloaded_cli_dir}"

blobstore_clis=(bosh-blobstore-dav bosh-blobstore-gcs bosh-blobstore-s3)
blobstore_clis=(bosh-blobstore-dav bosh-blobstore-gcs bosh-blobstore-s3 bosh-blobstore-az)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the package name to bosh-blobstore-azure-storage corresponding to the definition in azure-storage-cli repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Malsourie
Copy link

Please also adapt the filename of three assets files .sha256sum, .url and .version to bosh-blobstore-azure-storage

@rkoster rkoster requested review from a team, bgandon, danielfor and nouseforaname and removed request for a team and bgandon July 20, 2023 14:14
@rkoster
Copy link
Contributor

rkoster commented Jul 20, 2023

This PR should be coordinated with the agent changes.

@ramonskie
Copy link
Contributor

and it should also coordinated with the changes to the stemcell ci builder
see https://github.com/cloudfoundry/bosh-stemcells-ci/blob/master/pipelines/ubuntu-jammy/pipeline.yml#L1399
and https://github.com/cloudfoundry/bosh-stemcells-ci/blob/master/pipelines/ubuntu-jammy/stemcells.yml#L31
for the changes needed

@ten4o ten4o mentioned this pull request Jul 24, 2023
Merged
@Malsourie Malsourie mentioned this pull request Jul 25, 2023
Closed
5 tasks
@mvach
Copy link

mvach commented Jul 26, 2023

lgtm

mvach
mvach reviewed Jul 26, 2023
View reviewed changes
stemcell_builder/stages/blobstore_clis/assets/bosh-blobstore-azure-storage.version
@@ -0,0 +1 @@
0.0.7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed That there is a 0.0.8 already

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should auto update later on when the cloudfoundry/bosh-stemcells-ci#14 pr is merged

@rkoster rkoster requested a review from ramonskie August 3, 2023 15:08
ramonskie
ramonskie approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@ramonskie ramonskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkoster rkoster merged commit b2cfee5 into cloudfoundry:ubuntu-jammy/master Aug 3, 2023
@rkoster
Copy link
Contributor

rkoster commented Aug 3, 2023

Thanks! @ten4o

@mvach mvach mentioned this pull request Aug 4, 2023
Closed
cf-bosh-ci-bot pushed a commit that referenced this pull request Aug 11, 2023
@rkoster
Merge pull request #295 from ten4o/add-azure-storage-cli
f969a92 
Add azure-storage-cli to the stemcells
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvach mvach mvach approved these changes

@rkoster rkoster rkoster approved these changes

@ramonskie ramonskie ramonskie approved these changes

@Malsourie Malsourie Malsourie approved these changes

@danielfor danielfor Awaiting requested review from danielfor danielfor was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

@nouseforaname nouseforaname Awaiting requested review from nouseforaname nouseforaname was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ten4o @Malsourie @rkoster @ramonskie @mvach