fix issue with tar paths when compressing on windows #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tar` only recognizes forward slashes, so replace any windows backslash with a forward slash Signed-off-by: Chris Selzo <chris.selzo@broadcom.com>
selzoc
approved these changes
Nov 19, 2024
rkoster
reviewed
Nov 20, 2024
| relPath = relPath + "/" | ||
| header.Name = relPath | ||
| if runtime.GOOS == "windows" { | ||
| header.Name = strings.ReplaceAll(relPath, "\\", "/") |
There was a problem hiding this comment.
I'm trying to understand how this fixes anything, given that this looks really similar to what https://pkg.go.dev/path/filepath#FromSlash is supposed to be doing:
FromSlash returns the result of replacing each slash ('/') character in path with a separator character. Multiple slashes are replaced by multiple separators.
There was a problem hiding this comment.
https://pkg.go.dev/archive/tar#FileInfoHeader already appends a / if the path in question is a directory.
We also found that FromSlash does not convert \ to /: https://go.dev/play/p/SxWQTZfK3VO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taronly recognizes forward slashes, so replace any windows backslash with a forward slash