update java to jdk 17 #2515
Merged
update java to jdk 17 #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a follow up to: fc9bf38 shortly after requiring jdk11, credhub updated once again to require jdk17: cloudfoundry/credhub@f1897e4 unfortunately that wasn't noticed when creating the previous jdk11 update.
ramonskie
approved these changes
May 2, 2024
|
We're currently moving away from using the java in the docker image to run UAA and instead using the bosh release. So we might at some point end up ripping this out of the image, but for now we'll leave it in. |
selzoc
added a commit
that referenced
this pull request
May 8, 2024
Previous to this commit, the integration tests used a very very old version of UAA (3.5.0) from an s3 bucket that needed Java 8. Updates to the integration Docker image that raised the JDK from 8->17 caused this very old version to explode. This commit represents a major refactoring of how UAA runs in the integration specs. * The UAA version now tracks the version in bosh-deployment * There is only 1 UAA started, as opposed to 1 per spec process * The UAA version is from uaa-release, and is templated accordingly Java upgrade PRs: * #2154 * #2515 * #2516 Co-authored-by: Aram Price <aram.price@broadcom.com> Co-authored-by: Chris Selzo <chris.selzo@broadcom.com>
selzoc
added a commit
that referenced
this pull request
May 8, 2024
Previous to this commit, the integration tests used a very very old version of UAA (3.5.0) from an s3 bucket that needed Java 8. Updates to the integration Docker image that raised the JDK from 8->17 caused this very old version to explode. This commit represents a major refactoring of how UAA runs in the integration specs. * The UAA version now tracks the version in bosh-deployment * There is only 1 UAA started, as opposed to 1 per spec process * The UAA version is from uaa-release, and is templated accordingly Java upgrade PRs: * #2514 * #2515 * #2516 Co-authored-by: Aram Price <aram.price@broadcom.com> Co-authored-by: Chris Selzo <chris.selzo@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a follow up to:
fc9bf38
shortly after requiring jdk11, credhub updated once again to require jdk17: cloudfoundry/credhub@f1897e4
unfortunately that wasn't noticed when creating the previous jdk11 update.