Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DB_TLS option from integration specs #2541

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

aramprice
Copy link
Member

@aramprice aramprice commented Aug 2, 2024

We never run specs w/o DB_TLS so there's no need for this conditionality.

What is this change about?

Remove untested code path from test infrastructure.

What tests have you run against this PR?

executing build 147400459 at https://bosh.ci.cloudfoundry.org/builds/147400459

How should this change be described in bosh release notes?

n/a

Does this PR introduce a breaking change?

This change is only to the test execution code not in bosh itself.

@aramprice aramprice force-pushed the remove-DB_TLS branch 2 times, most recently from ee5d068 to 24874b7 Compare August 5, 2024 18:52
@aramprice aramprice requested review from a team, xtreme-nitin-ravindran and anshrupani and removed request for a team August 5, 2024 23:31
We never run specs w/o DB_TLS so there's no need for this
conditionality.
@aramprice aramprice merged commit c5e229e into main Aug 9, 2024
4 checks passed
@aramprice aramprice deleted the remove-DB_TLS branch August 9, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants