Finish removing legacy deployment helper ("ignoring cloud config when networks are present" feature)
#2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This spec is testing "ignoring cloud config when `networks` are present" which is a feature that was removed [on May 21, 2019](1be5ead). This commit exposes an invalid test setup which used `Config#make` with `raw_manifest:` which _does not_ actually set the `content` atribute of `Config` - likely due to limitations in the `machinest` gem.
The spec context was testing "ignoring cloud config when `networks` are present" which is a feature that was removed [on May 21, 2019](1be5ead).
This option is not used in produciton code and the capability to "ignoring cloud config when `networks` are present" was removed on [May 21, 2019](1be5ead)
aramprice
force-pushed
the
finish-removing-legacy_deployment_helper
branch
from
725fbe5
to
dd43a3b
Compare
ystros
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capability to "[ignore] cloud config when
networksare present" was removed on May 21, 2019