Replace httpclient with net/http in bosh-monitor #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramprice
requested review from
selzoc,
a team and
nader-ziada
and removed request for
a team
aramprice
force-pushed
the
replace-httpclient
branch
2 times, most recently
from
ab25ae2
to
a1d7ee6
Compare
aramprice
force-pushed
the
replace-httpclient
branch
3 times, most recently
from
3f21896
to
4bd9d9d
Compare
Two methods in `Plugins::HttpRequestHelper` used the [httpclient gem](https://github.com/nahi/httpclient) to make HTTP(S) requests. This PR replaces that gem with Ruby's built-in `net/http` gem. This change required modifying some of the callers of `HttpRequestHelper` (in bosh-director) since the response object from `net/http` differs slightly from `httpclient`'s, as well as the more mocked portions of the spec for `HttpRequestHelper` which relied on `httpclient` internals. In addtions the two "sync" methods now return `[body, status]` instead opf the http client's internal `Response`. This is the same pattern as the other Async methods. Signed-off-by: Brian Upton <brian.upton@broadcom.com>
Signed-off-by: Brian Upton <brian.upton@broadcom.com>
... only from an asynchronous context. Signed-off-by: Brian Upton <brian.upton@broadcom.com>
aramprice
force-pushed
the
replace-httpclient
branch
from
4bd9d9d
to
cbf2f3e
Compare
xtreme-nitin-ravindran
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two methods in
Plugins::HttpRequestHelperused the httpclient gem to make HTTP(S) requests. This PR replaces that gem with Ruby's built-innet/httpgem.This change required modifying some of the callers of
HttpRequestHelper(in bosh-director) since the response object fromnet/httpdiffers slightly fromhttpclient's, as well as the more mocked portions of the spec forHttpRequestHelperwhich relied onhttpclientinternals.