Address duplicate load warnings #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- shared examples live under `spec/shared_examples/` This change should reduce "has been previously defined at" warnings
Previously a generic `double()` was being returned `as_null_object` which allowed any number of method chains to be called. This commit changes the object to be a set of instance doubles with one specific method `#can_sign_urls?` explicitly stubbed on `Bosh::Blobstore::BaseClient` as `false` which would have been the value returned in the "null object" case.
aramprice
force-pushed
the
address-duplicate-load-warnings
branch
from
41e1784
to
60046ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration specs:
https://bosh.ci.cloudfoundry.org/builds/163543173