Add travis-ci support #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating cached gems fixing test pollution add travis.yml Change-Id: Ic1b0e44bf0022ea757f76a3ad91c02c96a2dd81e
dpb587-pivotal
pushed a commit
that referenced
this pull request
Aug 7, 2017
Handle bosh-gcscli credentials_source semantics
klakin-pivotal
added a commit
that referenced
this pull request
Dec 3, 2024
This commit fixes a production problem in certain environments with Bosh Director v280.1.10 and presumably later. For reasons unknown to us, in these environments, the 'to_str' function is not defined on the URI::HTTPS class. However, in MOST environments, it totally is. This is important, because the URI#parse function (which Async::HTTP::Endpoint.parse eventually calls) calls 'to_str' on the argument passed to it. Rather than figure out what's suddenly stopped injecting 'to_str' on the URI::HTTPS class, we're just passing in the type of data the functions require, rather than hoping it'll get automagically converted into the correct type. A heavily-elided stack trace from the troublesome environment in question follows. It may or may not be helpful context. E, [2024-12-03T02:50:26.105758 #6] ERROR : Unable to send get /deployments to director: Invalid URI: 'https://10.50.4.42:25555/info' -- /var/vcap/data/packages/director-ruby-3.2/0272ccbfccc42016eee9ff4d650e36c6bcadefb4/lib/ruby/3.2.0/uri/rfc3986_parser.rb:17:in `rescue in split': bad URI(is not URI?): #<URI::HTTPS https://10.50.4.42:25555/info> (URI::InvalidURIError) from /var/vcap/data/packages/director-ruby-3.2/0272ccbfccc42016eee9ff4d650e36c6bcadefb4/lib/ruby/3.2.0/uri/rfc3986_parser.rb:14:in `split' ... from /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/bosh-monitor-0.0.0/lib/bosh/monitor/director.rb:59:in `perform_request' ... from /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/async-2.20.0/lib/async/task.rb:435:in `block in schedule' /var/vcap/data/packages/director-ruby-3.2/0272ccbfccc42016eee9ff4d650e36c6bcadefb4/lib/ruby/3.2.0/uri/rfc3986_parser.rb:15:in `split': undefined method `to_str' for #<URI::HTTPS https://10.50.4.42:25555/info> (NoMethodError) uri = uri.to_str ^^^^^^^ Did you mean? to_s from /var/vcap/data/packages/director-ruby-3.2/0272ccbfccc42016eee9ff4d650e36c6bcadefb4/lib/ruby/3.2.0/uri/rfc3986_parser.rb:71:in `parse' ... from /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/bosh-monitor-0.0.0/lib/bosh/monitor/director.rb:59:in `perform_request' ... from /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/async-2.20.0/lib/async/task.rb:435:in `block in schedule' E, [2024-12-03T02:50:26.105953 #6] ERROR : /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/bosh-monitor-0.0.0/lib/bosh/monitor/director.rb:69:in `rescue in perform_request' /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/bosh-monitor-0.0.0/lib/bosh/monitor/director.rb:66:in `perform_request' ... Signed-off-by: Nitin Ravindran <nitin.ravindran@broadcom.com>
aramprice
pushed a commit
that referenced
this pull request
Dec 4, 2024
This commit fixes a production problem in certain environments with Bosh Director v280.1.10 and presumably later. For reasons unknown to us, in these environments, the 'to_str' function is not defined on the URI::HTTPS class. However, in MOST environments, it totally is. This is important, because the URI#parse function (which Async::HTTP::Endpoint.parse eventually calls) calls 'to_str' on the argument passed to it. Rather than figure out what's suddenly stopped injecting 'to_str' on the URI::HTTPS class, we're just passing in the type of data the functions require, rather than hoping it'll get automagically converted into the correct type. A heavily-elided stack trace from the troublesome environment in question follows. It may or may not be helpful context. E, [2024-12-03T02:50:26.105758 #6] ERROR : Unable to send get /deployments to director: Invalid URI: 'https://10.50.4.42:25555/info' -- /var/vcap/data/packages/director-ruby-3.2/0272ccbfccc42016eee9ff4d650e36c6bcadefb4/lib/ruby/3.2.0/uri/rfc3986_parser.rb:17:in `rescue in split': bad URI(is not URI?): #<URI::HTTPS https://10.50.4.42:25555/info> (URI::InvalidURIError) from /var/vcap/data/packages/director-ruby-3.2/0272ccbfccc42016eee9ff4d650e36c6bcadefb4/lib/ruby/3.2.0/uri/rfc3986_parser.rb:14:in `split' ... from /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/bosh-monitor-0.0.0/lib/bosh/monitor/director.rb:59:in `perform_request' ... from /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/async-2.20.0/lib/async/task.rb:435:in `block in schedule' /var/vcap/data/packages/director-ruby-3.2/0272ccbfccc42016eee9ff4d650e36c6bcadefb4/lib/ruby/3.2.0/uri/rfc3986_parser.rb:15:in `split': undefined method `to_str' for #<URI::HTTPS https://10.50.4.42:25555/info> (NoMethodError) uri = uri.to_str ^^^^^^^ Did you mean? to_s from /var/vcap/data/packages/director-ruby-3.2/0272ccbfccc42016eee9ff4d650e36c6bcadefb4/lib/ruby/3.2.0/uri/rfc3986_parser.rb:71:in `parse' ... from /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/bosh-monitor-0.0.0/lib/bosh/monitor/director.rb:59:in `perform_request' ... from /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/async-2.20.0/lib/async/task.rb:435:in `block in schedule' E, [2024-12-03T02:50:26.105953 #6] ERROR : /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/bosh-monitor-0.0.0/lib/bosh/monitor/director.rb:69:in `rescue in perform_request' /var/vcap/data/packages/health_monitor/d17d70b0dde3173e76cc1924bb9a1fceb045a9e2/gem_home/ruby/3.2.0/gems/bosh-monitor-0.0.0/lib/bosh/monitor/director.rb:66:in `perform_request' ... Signed-off-by: Nitin Ravindran <nitin.ravindran@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deletes the cpi_test_spec as it was red and is replaced by the bat tests.
bumps a lot of the cached gems