Skip to content

Commit

Permalink
Remove two problematic characters from Routing Transparency test (#1277)
Browse files Browse the repository at this point in the history
* preserving double quotes but not for HTTP/2
  • Loading branch information
dimivel authored Oct 18, 2024
1 parent aa6a1cb commit 084a4f5
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions apps/routing_transparency.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,17 @@ var _ = AppsDescribe("Routing Transparency", func() {
})

It("appropriately handles certain reserved/unsafe characters", func() {
curlResponse := helpers.CurlApp(Config, appName, "/requesturi/!~^'()$\"?!'()$#!'")
curlResponse := helpers.CurlApp(Config, appName, "/requesturi/!~^'()$?!'()$#!'")
Expect(curlResponse).To(ContainSubstring("Request"))

By("preserving all characters")
Expect(curlResponse).To(ContainSubstring("/requesturi/!~^'()$\""))
Expect(curlResponse).To(ContainSubstring("/requesturi/!~^'()$"))
Expect(curlResponse).To(ContainSubstring("Query String is [!'()$]"))

By("preserving double quotes (not for HTTP/2)")
if !Config.GetIncludeHTTP2Routing() {
curlResponse = helpers.CurlApp(Config, appName, "/requesturi/\"")
Expect(curlResponse).To(ContainSubstring("/requesturi/\""))
}
})
})

0 comments on commit 084a4f5

Please sign in to comment.