fix: Delete service brokers after tests #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an inconsistency in the credhub, docker, and route_services test suites (vs other suites) where apps were not get deleted after tests. Specifically, some service brokers that were pushed as apps were not getting deleted, only unregistered as service brokers. I ran through some of the steps manually and saw that the delete-service-broker command did not also delete the service broker app. Spot-checking the credhub suite, I couldn't find any reasons in git or tracker stories for the delete command to not to be originally included. Possibly, it was believed that the delete-service-broker command would delete the app...
jochenehret
approved these changes
Jun 4, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
Yes
What is this change about?
Fixes an inconsistency in the credhub, docker, and route_services test suites (vs other suites) where apps were not get deleted after tests. Specifically, some service brokers that were pushed as apps were not getting deleted, only unregistered as service brokers.
I ran through some of the steps manually and saw that the delete-service-broker command did not also delete the service broker app.
Please provide contextual information.
Spot-checking the credhub suite, I couldn't find any reasons in git or tracker stories for the delete command to not to be originally included. Possibly, it was believed that the delete-service-broker command would delete the app...
What version of cf-deployment have you run this cf-acceptance-test change against?
v33.4.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
About the same.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
None