Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1.22 as the go directive instead of 1.22.0 #1190

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Aug 13, 2024

Are you submitting this PR against the develop branch?

Yes

What is this change about?

Updates assets and base go.mod to use 1.22 as the go directive instead of 1.22.0. Some tooling in buildpacks depends upon the go directive being only in . format. And it seems like the base go.mod should match.

Please provide contextual information.

043a63f#commitcomment-145272348

What version of cf-deployment have you run this cf-acceptance-test change against?

None

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

None

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

None

Updates assets and base go.mod to use 1.22 as the go directive instead
of 1.22.0. Some tooling in buildpacks depends upon the go directive
being only in <major>.<minor> format. And it seems like the base go.mod
should match.
@ctlong ctlong changed the title Use 1.22 as the go directive Use 1.22 as the go directive instead of 1.22.0 Aug 13, 2024
@ctlong ctlong requested review from a team August 15, 2024 22:06
Copy link
Contributor

@dimivel dimivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davewalter davewalter merged commit 5e39b58 into develop Aug 16, 2024
1 check passed
@davewalter davewalter deleted the use-1.22-go-directive branch August 16, 2024 15:55
@ctlong ctlong mentioned this pull request Aug 17, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants