UAA v75 CAT flakes #456
Merged
UAA v75 CAT flakes #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The test was expecting the UAA authorization code to only contain letters and numbers, which was a incorrect expectation. For example, as of today, the code can contain dashes "-". * The regex was updated so that the code can contain any character. If the UAA decides one day to add another CGI parameter to the redirect URL, the test won't break because of the "^&" in the regex. * The '\r' and '\n' are there to end the regex match at the end of the line. * For context, this is what an UAA API response looks like. See line 6 the code we are trying to extract. HTTP/2 302 cache-control: no-store content-language: en-US content-length: 0 date: Tue, 02 Feb 2021 22:10:17 GMT location: http://example.com?code=gfCMdm9L3P # <- code here strict-transport-security: max-age=31536000 x-content-type-options: nosniff x-frame-options: DENY x-vcap-request-id: 82abfda5-bf9c-4790-726a-b45d20d8883c x-xss-protection: 1; mode=block via: 1.1 google alt-svc: clear Co-Authored-By: Bruce Ricard <bricard@vmware.com>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/176773740 The labels on this github issue will be updated when the story is started. |
|
|
jamespollard8
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was expecting the UAA authorization code to only contain
letters and numbers, which was a incorrect expectation. For example,
as of today, the code can contain dashes "-".
The regex was updated so that the code can contain any character. If
the UAA decides one day to add another CGI parameter to the redirect
URL, the test won't break because of the "^&" in the regex.
The '\r' and '\n' are there to end the regex match at the end of the
line.
For context, this is what an UAA API response looks like. See line 6
the code we are trying to extract.
HTTP/2 302
cache-control: no-store
content-language: en-US
content-length: 0
date: Tue, 02 Feb 2021 22:10:17 GMT
location: http://example.com?code=gfCMdm9L3P # <- code here
strict-transport-security: max-age=31536000
x-content-type-options: nosniff
x-frame-options: DENY
x-vcap-request-id: 82abfda5-bf9c-4790-726a-b45d20d8883c
x-xss-protection: 1; mode=block
via: 1.1 google
alt-svc: clear
Are you submitting this PR against the develop branch?
Yes!
What is this change about?
Fixing the CATs compatibility with UAA.
Please provide contextual information.
https://cloudfoundry.slack.com/archives/C03FXANBV/p1612201884012700
What version of cf-deployment have you run this cf-acceptance-test change against?
latest
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How many more (or fewer) seconds of runtime will this change introduce to CATs?
0
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@reedr3 , @peterhaochen47