Make app summary memory and disk units optional #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cloud controller returns zero for memory and disk quotas, units are not displayed
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/177065935 The labels on this github issue will be updated when the story is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
We recently changed the process stats endpoint to return the actual disk and memory quotas rather than the desired quotas from the cloud controller database. When these metrics have not been propagated to log cache, ccng returns zeros, and the CLI does not display units.
Please provide contextual information.
Associated Github Issue: cloudfoundry/cloud_controller_ng#2098
What version of cf-deployment have you run this cf-acceptance-test change against?
Latest
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How should this change be described in cf-acceptance-tests release notes?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
0 seconds
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@sethboyles @tstannard @elenasharma