Replaced all v2 API calls with v3 calls #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/177251511 The labels on this github issue will be updated when the story is started. |
matt-royal
reviewed
Mar 9, 2021
| @@ -288,13 +279,13 @@ var _ = ServicesDescribe("Service Instance Lifecycle", func() { | |||
| Expect(bindService).To(Exit(0), "failed binding app to service") | |||
| }) | |||
|
|
|||
| Context("when there is an existing binding", func() { | |||
| FContext("when there is an existing binding", func() { | |||
There was a problem hiding this comment.
I don't think you meant to leave this focus (and the one below) in
There was a problem hiding this comment.
Thanks for catching it. I removed it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#177245959
Are you submitting this PR against the develop branch?
All PR's to CATs should be submitted to develop and will be merged to main once they've passed acceptance.
What is this change about?
Services test relly only on v3 CAPI endpoints.
What version of cf-deployment have you run this cf-acceptance-test change against?
v16.5.0
Please check all that apply for this PR:
How should this change be described in cf-acceptance-tests release notes?
Services test relly only on v3 CAPI endpoints.
What is the level of urgency for publishing this change?