Run dotnet core buildpack test with published app versions for different stacks #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unpublished dotnet app needs access to NuGet registry, even for apps that have no dependencies. dotnet-core buildpack is running `dotnet publish` on unpublished apps and that runs nuget restore which pulls dotnet core and asp net core libraries from registry. Published apps need to be published on the same distribution where they are going to run. E.g. cflinuxfs3 apps need to be published on ubuntu 18.04.
7 tasks
ctlong
requested changes
Sep 30, 2022
* add Makefile to generate cflinuxfs3 and cflinuxfs4 versions
mariash
force-pushed
the
dotnet-published-on-18.04
branch
from
0e2e0ea to
42912bd
Compare
ctlong
approved these changes
Sep 30, 2022
|
We've just noticed that this PR introduces a large amount of resource files to the Are you aware of this problem? Can you reduce the application's resources? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
Yes
What is this change about?
dotnet core buildpack will reach NuGet registry for unpublished apps to get dotnet core library. That makes this test fail in internetless environment. Switch to using published app (e.g. vendor everything). Published apps need to be compiled for the runtime they will be running on, so there are 2 published versions included for cflinuxfs3 and cflinuxfs4.
Makefile is provided to help rebuild those versions in case of code changes.
Please provide contextual information.
Slack thread https://vmware.slack.com/archives/CUR2H2KFE/p1663189449408889
What version of cf-deployment have you run this cf-acceptance-test change against?
e8130a2c616c4c27e215030e571dc441409f9f5b
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How many more (or fewer) seconds of runtime will this change introduce to CATs?
It actually makes it faster because it skips compilation and fetching dependencies during staging.
What is the level of urgency for publishing this change?