Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace ioutil use as the package is deprecated #691

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Dec 29, 2022

Are you submitting this PR against the develop branch?

Yes

What is this change about?

ioutil has been deprecated since Go 1.16 and should be replaced with io and os functions.

Please provide contextual information.

None

What version of cf-deployment have you run this cf-acceptance-test change against?

None

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

None

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

None

ioutil has been deprecated since Go 1.16 and can be completely replaced
with io and os functions.
@ctlong ctlong requested a review from a team January 3, 2023 19:32
Copy link
Member

@Benjamintf1 Benjamintf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@ctlong ctlong merged commit 2a66beb into develop Jan 9, 2023
@ctlong ctlong deleted the fix/replace-ioutil branch January 9, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants