Remove extra space from zipkin header #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing failure on go 1.19 Signed-off-by: Marc Paquette <mpaquette@vmware.com>
ctlong
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing failure on go 1.19
Signed-off-by: Marc Paquette mpaquette@vmware.com
Are you submitting this PR against the develop branch?
Yes
What is this change about?
Remove trailing space in the Zipkin header X-B3-TraceId. Looks like a typo. This is causing test failures in go 1.19.4.
What version of cf-deployment have you run this cf-acceptance-test change against?
This test was run against TAS 4.0.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
What is the level of urgency for publishing this change?