Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(bbl-up): Use correct flags for new yq CLI #169

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Oct 5, 2023

What is this change about?

Fix failures in bbl-up task in CI by using the correct flags for the new yq CLI.

Please provide contextual information.

Please check all that apply for this PR:

  • introduces a new task
  • changes an existing task
  • changes the Dockerfile
  • introduces a breaking change (other users will need to make manual changes when this is released)

Did you update the README as appropriate for this change?

  • YES
  • N/A

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

N/A

ctlong added 2 commits October 4, 2023 19:18
It appears that we used to use `kislyuk/yq` but #167 switched us to
`mikefarah/yq` unintentionally.

It appears that `--output-format yaml` will work for `mikefarah/yq` the
same way that `--yaml-output` worked for `kislyuk/yq`.
@ctlong ctlong requested a review from a team October 5, 2023 02:30
@jochenehret jochenehret merged commit 7596b01 into main Oct 5, 2023
@jochenehret jochenehret deleted the fix/bbl-up/use-new-flags branch October 5, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants