Introduce LoggregatorV2 Client #1021
Conversation
There was a problem hiding this comment.
Hi @enchobelezirev - my apologies for the delay, I can now give this the attention it deserves. Everything looks good, but we need some tests adding to prove the functionality. I've tried to give pointers to what they should look like. Thanks for the submission, I look forward to incorporating it soon!
| import reactor.core.publisher.Mono; | ||
|
|
||
| @Value.Immutable | ||
| abstract class _ReactorLoggregatorClient implements LoggregatorClient { |
There was a problem hiding this comment.
Requires tests in line with ReactorDopplerClientTest
| @@ -41,6 +42,30 @@ public static ContainerMetric from(org.cloudfoundry.dropsonde.events.ContainerMe | |||
| .build(); | |||
| } | |||
|
|
|||
| public static ContainerMetric from(LoggregatorEnvelope.Envelope envelope) { | |||
There was a problem hiding this comment.
Requires tests in line with ContainerMetricTests
| @@ -36,6 +37,15 @@ public static CounterEvent from(org.cloudfoundry.dropsonde.events.CounterEvent d | |||
| .total(dropsonde.total) | |||
| .build(); | |||
| } | |||
| public static CounterEvent from(LoggregatorEnvelope.Counter counter) { | |||
There was a problem hiding this comment.
Requires tests in line with CounterEventTests
| @@ -40,6 +42,20 @@ public static LogMessage from(org.cloudfoundry.dropsonde.events.LogMessage drops | |||
| .build(); | |||
| } | |||
|
|
|||
| public static LogMessage from(LoggregatorEnvelope.Envelope envelope) { | |||
There was a problem hiding this comment.
Requires tests in line with LogMessageTests
| * The request payload for the Read endpoint | ||
| */ | ||
| @Value.Immutable | ||
| abstract class _StreamRequest { |
There was a problem hiding this comment.
Requires tests in line with the doppler StreamRequestTests
No description provided.