-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readiness health check support in client #1213
base: main
Are you sure you want to change the base?
Add readiness health check support in client #1213
Conversation
|
ab94811
to
833a8a1
Compare
Hi, @pivotal-david-osullivan, I saw that you have commited a lot of changes recently, so can you take a look at my PR. |
@Yavor16 thank you for the contribution! We are working through PRs at the moment. Could you please add integration test support to cover the new feature? Liveness health checks can be seen in the integration-test module in places such as here - test setting the type and here - setting the health check in an application push. |
Hi, @pivotal-david-osullivan, |
Hi, @pivotal-david-osullivan, |
hello @Yavor16 , sorry to ask you this late, but could you run It will fix the CI failure on Java 11 that runs the stylecheck Thank you! worst case, we'll do it ourselves |
Hello @Yavor16
or
or
or
Best guess is you missed a required JSON field named |
* make sure that we also compile the integration tests during Github CI
* when the extension has a mandatory field to initialize, because ExtendWith only works with default constructor
* add the extension registration declaratively (using an annotation)
adding create security group impl and tests adding get security group api and tests adding get security group impl + test adding list security groups impl + api adding update security group api adding update security group api v3 impl adding security groups delete api v3 impl and tests adding bind running/staging security group v3 api adding bind impl adding unbind security group adding list running/staging api and tests adding create security group test adding integration tests adding integration tests fixing setup/teardown fixing integration tests refactoring integration tests
* tests from radoslav commits
* cause they have interesting things to display
* on top of Hans Schulz "mask off non-permission bits"
porting delete orphaned routes pushing delete route cleaning up leftovers in tests applying default style and fixing missing imports
Hello, @anthonydahanne, |
Here is a gist with the my test results https://gist.github.com/Yavor16/2d6b9c4786242c2bf1eb3ebebe5383da |
a07bdfd
to
c748a4d
Compare
hello @Yavor16 We could merge this PR after we require a later version than 2.186.0 Thanks! |
Hello, @anthonydahanne |
I know about users willing to use the readiness health check blocked by this pr. From the platform side we are also interested to get more feedback for new features. It will be great if the CF Java client could support more recent versions of CAPI which will help also for the adoption of those new features. @pivotal-david-osullivan, @anthonydahanne is there a chance we find a good middle ground here? |
@beyhan , yes, we want to unblock this situation. |
@anthonydahanne Do you have some news on that? |
d8ab20c
to
60e1dc1
Compare
Hello @anthonydahanne |
The commit referenced adds some support for fields in newer CAPI versions. Integration tests are completing successfully for readiness health check on older supported CAPI, we are almost done with tests for the newer version. Once they are passing I plan to add a commit to this PR with some further additions and then we can merge it. |
60e1dc1
to
2845c36
Compare
No description provided.