Handling of expired access tokens when CF CC rate limiting exhausts #965
Conversation
|
❌ Hey hariyada! All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process. The following github user @hariyada is not covered by a CLA. After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s). |
|
✅ Hey hariyada! The commit authors and yourself have already signed the CLA. |
| Mono<String> accessToken = this.accessTokens.get(connectionContext); | ||
| if(accessToken != null) { | ||
| try { | ||
| String token = this.accessTokens.get(connectionContext).map(s -> s.split(" ")[1]).block(); |
There was a problem hiding this comment.
Making a .block() call is a significant code smell in a reactive project (note that, outside of a few specific tests, it's not used anywhere else in this project). This needs to be refactored into a reactive style.
| int i = expirationTime.compareTo(new Date()); | ||
| long milliSeconds = expirationTime.getTime() - new Date().getTime(); | ||
| // invalidate the token if it is going to be expired in one minute. | ||
| boolean isTokenInvalid = ((i <= 0) || (i == 1 && milliSeconds <= 60000)); |
There was a problem hiding this comment.
Inspection tells me that i == 1 (rather than i > 0 is bad practice).
| @@ -279,5 +305,12 @@ private RefreshToken getRefreshTokenStream(ConnectionContext connectionContext) | |||
| private FluxSink<String> sink = this.processor.sink(); | |||
|
|
|||
| } | |||
|
|
|||
| private static Optional<Claims> exctractClaimsFromToken(String token) { | |||
token handling for the below mentioned issue
issue link: #960