Remove -d flag option from push

[ctlong]

This flag was deprecated and removed from the cf push command.

cf-test-helpers/cf/push.go

Lines 45 to 46 in 36ed5ab

	case "-d":
	app.Routes = append(app.Routes, map[string]string{"route": fmt.Sprintf("%s.%s", appName, args[i+1])})

[ctlong]

tldr; this issue was misguided and the PR resolving it introduced a bug into CATs. We should find a way to remove it from cf-test-helpers.

I thought that I was removing the -d flag from cf push with my change, as that flag was deprecated in cf CLI v7. However, the Push function in cf-test-helpers actually generates an application manifest and uses that manifest to cf push the application. Removing the -d option from the Push function removed the option to populate the routes field of the application manifest, which certain CATs isolation segment tests relied upon.

• https://cloudfoundry.slack.com/archives/C033ALST37V/p1664463227639259
• https://cloudfoundry.slack.com/archives/C01ABMVNE9E/p1664484810271339?thread_ts=1664482646.299389&cid=C01ABMVNE9E

[ctlong]

My proposal is to revert #71 and cut a patch release. Then to update the release descriptions to make it clear what happened.

If we don't care about the release history, we could also just revert #71 and delete the v2.1.0 release.

[ctlong]

The revert commit is included in in the v2.2.0 release.