Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support distributed tracing #7

Merged
merged 4 commits into from
May 23, 2023
Merged

Support distributed tracing #7

merged 4 commits into from
May 23, 2023

Conversation

mariash
Copy link
Member

@mariash mariash commented May 12, 2023

Please provide the following information:

What is this change about?

Generate trace ID and pass it to BBS client in each command.

What problem it is trying to solve?

Being able to trace the same request across multiple components.

What is the impact if the change is not made?

Difficulty correlating actions happening in different components

How should this change be described in diego-release release notes?

Add distributed tracing to Diego component logs

Please provide any contextual information.

https://www.pivotaltracker.com/story/show/183997277

Thank you!

Copy link
Contributor

@ebroberson ebroberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariash mariash merged commit ef69fb6 into main May 23, 2023
@mariash mariash deleted the d-tracing branch May 23, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants