Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update html5-plugin to 1.4.6 #384

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Update html5-plugin to 1.4.6 #384

merged 2 commits into from
Mar 1, 2021

Conversation

micellius
Copy link
Contributor

@micellius micellius commented Feb 16, 2021

Thank you for contributing to the CF CLI Plugin Repository!

This repo contains both the plugin repo server and the metadata for CLI
community plugins.
Some of the requirements for PRs will apply to only one of these parts.

We're not allowed to accept any PRs without a signed CLA, no matter how small.
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.

Submitting Plugins

If you haven't yet, please review our contributing guidelines:
https://github.com/cloudfoundry/cli-plugin-repo#submitting-plugins

In particular ensure the following requirements are being met:

  • The plugin's name field in repo-index.yml matches the Name field in the plugin's plugin.PluginMetadata section
  • The plugin's url field in repo-index.yml contains the same version from the version field

Submitting PRs to CLIPR (the CLI Plugin Repo server)

All new code requires tests to protect against regressions.

Description of the Change

This is a minor update that allows to leverage additional configuration option in multiple commands provided by the plugin (with -di option), which brings convenience to the end-users and automates the setup required to consume HTML5 applications on SAP Business Technology Platform (former SAP Cloud Platform). The change also addresses some bug fixes and simplifies the process of HTML5 applications discovery when custom runtime is used to serve HTML5 applications (with -rt option).

Why Is This PR Valuable?

With this PR users would gain convenient way of installing/updating the latest version of CF CLI plugin.

Applicable Issues

How Urgent Is The Change?

The change is not time-sensitive and may be handled with medium priority.

Other Relevant Parties

The change is backward-compatible and other parties should not be affected.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 16, 2021

CLA Signed

The committers are authorized under a signed CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176962534

The labels on this github issue will be updated when the story is started.

@micellius micellius closed this Feb 16, 2021
@micellius micellius reopened this Feb 16, 2021
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176963166

The labels on this github issue will be updated when the story is started.

@a-b a-b merged commit 48fc087 into cloudfoundry:master Mar 1, 2021
@IObert
Copy link

IObert commented Mar 5, 2021

@a-b I noticed that the latest plugin version is still missing here https://plugins.cloudfoundry.org/

Actually, the result of the last PR (#375) is also still missing here. Is there something broken in the CI/CD pipeline?

@a-b
Copy link
Member

a-b commented Mar 5, 2021

Thanks for reporting!

We will take a look and get back to you shortly. I suspect this has something to do with broken CD related to the recent migration of our infrastructure.

@IObert
Copy link

IObert commented Mar 31, 2021

@a-b I'm sorry to bother you. Do you have any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants