Refresh token in logs is disabled for Korifi #2295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Configured with `Config.IsCFOnK8s` Co-authored-by: Clint Yoshimura <clinty@vmware.com>
|
Requested review from cli team as i no longer have cli context |
jdgonzaleza
requested review from
jdgonzaleza,
a-b and
pivotalgeorge
and removed request for
a-b and
pivotalgeorge
|
Closing and moving conversation to #2294. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR modify CLI v6, CLI v7, or CLI v8?
CLI v8. A corresponding PR is open for the v8 branch with #2294.
Description of the Change
Disables refresh token call for the
cf logscommand when targeting Korifi (CF on K8s). We are not using UAA for AuthN/Z, so this call was resulting in errors.Why Is This PR Valuable?
This will allow users of Korifi to use the
cf logscommand without causing an error on the refresh token call.Why Should This Be In Core?
This change extends previous core functionality to allow targeting of Korifi (CF on K8s) clusters.
Applicable Issues
[Feature]: CF CLI user can skip oauth/token requests on Korifi
How Urgent Is The Change?
This PR to update master is lower priority than #2294.
Other Relevant Parties
Korifi users.