Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: speedup pak command in tests #413

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

tinygrasshopper
Copy link
Contributor

added caching which can be turned on by setting an enviornment variable on local
to speedup your local dev loops while running pak

[#181404983]

Signed-off-by: James Norman normanja@vmware.com

Checklist:

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/181523489

The labels on this github issue will be updated when the story is started.

@blgm
Copy link
Member

blgm commented Mar 10, 2022

  • Should there be changes to the Makefile to set the variable?
  • Does it make sense to expose this as a feature for brokerpak developers. Should there be a $HOME/.pakcache directory created as a default, to speed up the development process?

added caching which can be turned on by setting an enviornment variable on local
to speedup your local dev loops while running pak

[#181404983]

Signed-off-by: James Norman <normanja@vmware.com>
@tinygrasshopper tinygrasshopper force-pushed the add-caching-to-pak-command branch from 4126e7c to 7a28d3d Compare March 10, 2022 11:42
@tinygrasshopper
Copy link
Contributor Author

tinygrasshopper commented Mar 10, 2022

  • Should there be changes to the Makefile to set the variable?

Makes sense, added a new task to run integration tests cached. We dont want to change the default ci/flow to this one

  • Does it make sense to expose this as a feature for brokerpak developers. Should there be a $HOME/.pakcache directory created as a default, to speed up the development process?

Makes sense, added $PWD/.pak-cache instead

@tinygrasshopper tinygrasshopper merged commit 6518b74 into main Mar 10, 2022
@tinygrasshopper tinygrasshopper deleted the add-caching-to-pak-command branch March 10, 2022 11:56
@tinygrasshopper tinygrasshopper restored the add-caching-to-pak-command branch March 10, 2022 11:59
@blgm blgm deleted the add-caching-to-pak-command branch November 25, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants