chore: improve tofu handling #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core now defaults to the tofu url template for tofu binaries. It still defaults to hashicorp for providers as this is the download url (where releases are hosted) and not the registry itself. [#187199931](https://www.pivotaltracker.com/story/show/187199931)
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187271426 The labels on this github issue will be updated when the story is started. |
blgm
approved these changes
Mar 20, 2024
| if currentTfVersion.LessThan(version.Must(version.NewVersion("0.12.0"))) { | ||
| return errors.New("upgrade only supported for Terraform versions >= 0.12.0") | ||
| if currentTfVersion.LessThan(version.Must(version.NewVersion("1.5.0"))) { | ||
| return errors.New("upgrade only supported for Terraform versions >= 1.5.0") |
There was a problem hiding this comment.
Should the word Terraform still be here?
There was a problem hiding this comment.
strictly speaking, people will need to migrate from terraform 1.5.7 to opentofu 1.6.x. There's no opentofu version 1.5.x so I believe in this case, terraform is fine. I could change by Terraform/OpenTofu
FelisiaM
approved these changes
Mar 20, 2024
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: