Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure bump rebase #2690

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Azure bump rebase #2690

merged 4 commits into from
Feb 22, 2022

Conversation

sethboyles
Copy link
Member

Contains bumps to our branch of fog-azure-rm, as well as to fog-google, and reverts the revert of the fog-aws bump.

rebase of #2685

this introduces a dependency on a custom branch of azure-storage-ruby (Azure/azure-storage-ruby#212). We discussed merging this PR in for now with the back up plan of rewriting some internal fog-azure-rm code (which @tjvman and I have already spiked) in order to remove that custom branch dependency, in case our PR doesn't get merged in a timely manner

sethboyles and others added 3 commits February 18, 2022 17:50
* we have to use a special branch of azure-storage-ruby for now until
its merged in

Co-authored-by: Seth Boyles <sboyles@pivotal.io>
Co-authored-by: Tom Viehman <tviehman@pivotal.io>
…/bundler/fog-aws-3.12.0""

This reverts commit 197a975.
Authored-by: Seth Boyles <sboyles@pivotal.io>
@sethboyles sethboyles mentioned this pull request Feb 18, 2022
@sethboyles sethboyles requested a review from a team February 18, 2022 17:52
Copy link
Contributor

@sweinstein22 sweinstein22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, mostly making namespace adjustments and accounting for needed fixes to fog-google

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants