Service broker client: Set 'X-Api-Info-Location' according to 'temporary_enable_v2' #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary_enable_v2' * use /v2/info if true, and root context / for false
johha
approved these changes
Oct 31, 2024
Samze
approved these changes
Oct 31, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Nov 4, 2024
Changes in cloud_controller_ng:
- Service broker client: Set 'X-Api-Info-Location' according to 'temporary_enable_v2'
PR: cloudfoundry/cloud_controller_ng#4058
Author: Jochen Ehret <jochen.ehret@sap.com>
jochenehret
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Nov 4, 2024
3 tasks
5 tasks
jochenehret
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Nov 5, 2024
* Add temporary_enable_v2 flag to cc-worker config * required for cloudfoundry/cloud_controller_ng#4058 * Use BOSH links for temp_enable_v2 property * avoids redundant configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
For the service broker http client, set the 'X-Api-Info-Location' header to the
/v2/infoendpoint iftemporary_enable_v2istrue, and root context/iffalse.An explanation of the use cases your change solves
Part of the v2 deprecation story: [RFC] CF API v2 End of Life community#941
Links to any other associated PRs
Remove v2 section from / if temporary_enable_v2 == false #4034
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run [CF Acceptance Tests] -> will be run in https://concourse.app-runtime-interfaces.ci.cloudfoundry.org/teams/capi-team/pipelines/capi/jobs/gyro-exp-tests where v2 is completely disabled