Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove foreign key contraint in table job_warnings on 'fk_jobs_id' #4174

Merged
merged 1 commit into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Sequel.migration do
up do
unless foreign_key_list(:job_warnings).empty?
alter_table :job_warnings do
drop_foreign_key :fk_jobs_id
end
end
end
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
require 'spec_helper'
require 'migrations/helpers/migration_shared_context'

RSpec.describe "migration to remove foreign key constraint on table 'job_warnings' and column 'fk_jobs_id'", isolation: :truncation, type: :migration do
include_context 'migration' do
let(:migration_filename) { '20250116144231_remove_unnecessary_fk_in_job_warnings.rb' }
end

describe 'job_warnings table' do
it 'removes the fk constraint as well as the column' do
Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true)

expect(db.foreign_key_list(:job_warnings)).to be_empty
expect(db[:job_warnings].columns).not_to include(:fk_jobs_id)
end

context 'foreign key constraint does not exist' do
before do
unless db.foreign_key_list(:job_warnings).empty?
db.alter_table(:job_warnings) do
drop_foreign_key :fk_jobs_id
end
end
end

it 'does not fail' do
expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true) }.not_to raise_error
end
end
end
end
Loading