Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARP] working agreement: make reviewer workflow #163

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

ameowlia
Copy link
Member

@ameowlia ameowlia commented Oct 28, 2021

Please leave this PR open until the ARP working group discusses and votes.

This PR is built on top of #155

@ameowlia ameowlia force-pushed the arp-reviewer-workflow branch from 9dccc7e to d6e55fa Compare October 28, 2021 22:03
@geofffranks
Copy link
Contributor

+1

3 similar comments
@ctlong
Copy link
Member

ctlong commented Nov 8, 2021

+1

@Gerg
Copy link
Member

Gerg commented Nov 9, 2021

+1

@IvanHristov98
Copy link

+1

@ameowlia
Copy link
Member Author

4 votes for and 0 against. Accepted!

Copy link
Member

@dsboulder dsboulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very well thought out, thank you so much @ameowlia

@ameowlia ameowlia merged commit 9763791 into cloudfoundry:main Nov 30, 2021
@ameowlia ameowlia deleted the arp-reviewer-workflow branch November 30, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants