Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maria Shaldybin as Diego approver #434

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

mariash
Copy link
Member

@mariash mariash commented Sep 29, 2022

I'd like to be added as an approver in the Diego working group.

@ameowlia would you be willing to nominate me?

Submitted substantial PRs:

Reviewed substantial Issues:

Involved in technical discussions:

  • Dynamic ASGs
  • C2C over TLS
  • NATS v2
  • HTTP healthcheck Improvements

Resolved slack interrupts (in cloudfoundry.slack.com seach in:#diego from:@mariash).

My tenures:

  • I was an engineer on Volume Services (now part of Diego) team in 2018 - 2019.
  • I was an engineer on Diego team in mid 2019 - feb, 2020.
  • I have been an engineer on TAS Runtime team in aug, 2021 - present.

@ameowlia
Copy link
Member

ameowlia commented Sep 29, 2022

👍 I approve Maria's nomination.

Besides the things she listed she was also one of the main architects behind the dynamic ASG feature and she was the sole architect for TLS for c2c. Both of these large features spanned cf-networking, silk, and diego.

@Gerg Gerg requested review from Gerg and removed request for Gerg October 3, 2022 23:49
@ameowlia ameowlia merged commit 40f3c70 into cloudfoundry:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants