Use a 2-letters ISO 3166 country code, as required by RFC 2459

[bgandon]

Hi there,

In order to fix cloudfoundry/bosh#2473 and cloudfoundry/bosh-cli#632, here is a small patch so that the generated certificates have a valid 2-letters ISO 3166 country code, as required by RFC 2459 in Appendix A.

I’ve also written some short instructions for running unit and integration tests, based on my experience doing it today. About golangci-lint, I also wonder if this installation code is still relevant :
https://github.com/cloudfoundry/config-server/blob/master/bin/lint#L6-L11
Indeed, this way of doing is no more recommended, see https://golangci-lint.run/usage/install/#install-from-source, and I’ve not been able to run golangci-lint this way.

Cheers

[rkoster]

DO NOT MERGE!! We first need to figure out a way to roll out these changes without breaking director ← NATS → agent communication: https://github.com/cloudfoundry/bosh/blob/main/src/bosh-nats-sync/lib/nats_sync/nats_auth_config.rb#L32C1-L43C8

[bgandon]

On-going discussion in #2473.

[jpalermo]

I believe we decided there was no risk to these changes.

This code is pulled in by the bosh-cli and it will change how certificate variables are generated when doing a bosh create-env, but that will at most impact the CA/server cert generated for NATS, not any of the client certs, and the clients don't use the country for any sort of server validation.