Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: http method correction for mssql app #750

Merged
merged 1 commit into from
May 2, 2024
Merged

test: http method correction for mssql app #750

merged 1 commit into from
May 2, 2024

Conversation

blgm
Copy link
Member

@blgm blgm commented May 2, 2024

Fixes error:

panic: pattern "GET /{schema}/{key}" (registered at /tmp/build/17f8294a/brokerpak/acceptance-tests/apps/mssqlapp/internal/app/app.go:32) conflicts with pattern "HEAD /" (registered at /tmp/build/17f8294a/brokerpak/acceptance-tests/apps/mssqlapp/internal/app/app.go:27):
GET /{schema}/{key} matches more methods than HEAD /, but has a more specific path pattern

@blgm
test: http method correction for mssql app
dd6c1ec 
Fixes error:
```
panic: pattern "GET /{schema}/{key}" (registered at /tmp/build/17f8294a/brokerpak/acceptance-tests/apps/mssqlapp/internal/app/app.go:32) conflicts with pattern "HEAD /" (registered at /tmp/build/17f8294a/brokerpak/acceptance-tests/apps/mssqlapp/internal/app/app.go:27):
GET /{schema}/{key} matches more methods than HEAD /, but has a more specific path pattern
```

[#187470327](https://www.pivotaltracker.com/story/show/187470327)
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187537934

The labels on this github issue will be updated when the story is started.

zucchinidev
zucchinidev approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@zucchinidev zucchinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we used to use the HEAD HTTP method, but the Cloud Foundry documentation sais:

The http health check performs a GET request to the configured HTTP endpoint on the app’s default port.
I encountered the same errors a few days ago when modifying the AWS apps, but I forgot to mention it.

@FelisiaM FelisiaM merged commit b44bdbb into main May 2, 2024
8 checks passed
@blgm blgm deleted the chi2 branch May 2, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zucchinidev zucchinidev zucchinidev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Service Management Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blgm @cf-gitbot @zucchinidev @FelisiaM