fix: image_url value now works for GUI application #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#183058257](https://www.pivotaltracker.com/story/show/183058257) Signed-off-by: Konstantin Semenov <ksemenov@vmware.com>
blgm
reviewed
Sep 1, 2022
There was a problem hiding this comment.
This is a step in the right direction. The downside is that it's a bit clunky. Most of the service definition file is now taken up with a binary image.
As the the authors of the CSB, I think we could do something that's more future-proof. For example, we could have:
image_url: file://image.png
And the CSB pak build command could load the image from disk and encode it.
pivotal-marcela-campo
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#183058257
Checklist:
docs/draft-release-notes.md?