Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install ginkgo in correct version #704

Merged

Conversation

maxmoehl
Copy link
Member

No description provided.

@maxmoehl maxmoehl requested review from CFN-CI and a team as code owners August 22, 2024 07:48
@maxmoehl maxmoehl added the run-ci Allow this PR to be tested on Concourse label Aug 22, 2024
@maxmoehl maxmoehl force-pushed the maxmoehl/ginkgo-version branch 2 times, most recently from 4048078 to 56d2c3e Compare August 22, 2024 08:21
@maxmoehl
Copy link
Member Author

maxmoehl commented Aug 22, 2024

This is much more painful than I expected...

The newer image automatically installed a new Ruby version and now the unit-tests fail with:

Updating files in vendor/cache
The `rake` executable in the `haproxy-tools` gem is being loaded, but it's also present in other gems (rake).
If you meant to run the executable for another gem, make sure you use a project specific binstub (`bundle binstub <gem_name>`).
If you plan to use multiple conflicting executables, generate binstubs for them and disambiguate their names.
The `rake` executable in the `rake` gem is being loaded, but it's also present in other gems (haproxy-tools).
If you meant to run the executable for another gem, make sure you use a project specific binstub (`bundle binstub <gem_name>`).
If you plan to use multiple conflicting executables, generate binstubs for them and disambiguate their names.
rake aborted!
LoadError: cannot load such file -- racc/parser
<internal:/usr/local/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
<internal:/usr/local/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
/usr/local/bundle/ruby/3.3.0/gems/parser-3.2.2.1/lib/parser.rb:12:in `<top (required)>'
<internal:/usr/local/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
<internal:/usr/local/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
/usr/local/bundle/ruby/3.3.0/gems/rubocop-ast-1.28.1/lib/rubocop/ast.rb:3:in `<top (required)>'
/usr/local/bundle/ruby/3.3.0/gems/rubocop-ast-1.28.1/lib/rubocop-ast.rb:3:in `require_relative'
/usr/local/bundle/ruby/3.3.0/gems/rubocop-ast-1.28.1/lib/rubocop-ast.rb:3:in `<top (required)>'
<internal:/usr/local/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
<internal:/usr/local/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
/usr/local/bundle/ruby/3.3.0/gems/rubocop-1.50.2/lib/rubocop.rb:14:in `<top (required)>'
<internal:/usr/local/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
<internal:/usr/local/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
/usr/local/bundle/ruby/3.3.0/gems/rubocop-1.50.2/lib/rubocop/rake_task.rb:47:in `run_cli'
/usr/local/bundle/ruby/3.3.0/gems/rubocop-1.50.2/lib/rubocop/rake_task.rb:26:in `block (2 levels) in initialize'
/usr/local/bundle/ruby/3.3.0/gems/rubocop-1.50.2/lib/rubocop/rake_task.rb:24:in `block in initialize'
/usr/local/bundle/ruby/3.3.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/cli/exec.rb:58:in `load'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/cli/exec.rb:58:in `kernel_load'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/cli/exec.rb:23:in `run'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/cli.rb:492:in `exec'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/cli.rb:34:in `dispatch'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/cli.rb:28:in `start'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/exe/bundle:45:in `block in <top (required)>'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
/usr/local/bundle/ruby/3.3.0/gems/bundler-2.4.12/exe/bundle:33:in `<top (required)>'
/usr/local/bin/bundle:25:in `load'
/usr/local/bin/bundle:25:in `<main>'
Tasks: TOP => lint
(See full trace by running task with --trace)

I will push the old image again to allow the tests to run again. We will have to spend some time to understand what is going on.

@maxmoehl
Copy link
Member Author

So I came across ruby/ruby#7877 which seems to be the source of the issue, this triggered rubocop/rubocop#11942 which in turn got released with v1.52.1 so I'm now requiring at least that version.

@maxmoehl
Copy link
Member Author

Finally 🎉

@peanball peanball merged commit 8c15762 into cloudfoundry:master Aug 22, 2024
4 checks passed
@maxmoehl maxmoehl deleted the maxmoehl/ginkgo-version branch August 22, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-ci Allow this PR to be tested on Concourse
Development

Successfully merging this pull request may close these issues.

2 participants