You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A part of #681 we extended the functionality of the process_stats endpoint. Since the endpoint already existed, we did not add an e2e test for it.
Additionally we noticed that the MetricsFetcher uses a privileged client. As a nice-to-have evaluate wether or not this can be changed to a userclient.
Action to take
Write an e2e test for the GET process stats happy path-initially without metrics server present.
Adding the metrics server is nice-to-have
Adding the user client is nice-to-have
Impact
This will make the tests around metrics server usage more robust, and ensure that we did not make any RBAC mistakes.
Dev Notes
No response
The text was updated successfully, but these errors were encountered:
#706
- Adds metrics-server to kind deployment script
- Pins kpack ClusterStore node buildpack version to previous working one
- Adds an e2e test for the GET process_stats endpoint when metrics server is present
Co-authored-by: Ashwin Krishna <krishnaas@vmware.com>
Background
A part of #681 we extended the functionality of the process_stats endpoint. Since the endpoint already existed, we did not add an e2e test for it.
Additionally we noticed that the MetricsFetcher uses a privileged client. As a nice-to-have evaluate wether or not this can be changed to a userclient.
Action to take
Write an e2e test for the GET process stats happy path-initially without metrics server present.
Adding the metrics server is nice-to-have
Adding the user client is nice-to-have
Impact
This will make the tests around metrics server usage more robust, and ensure that we did not make any RBAC mistakes.
Dev Notes
No response
The text was updated successfully, but these errors were encountered: