Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]: Write e2e tests for GET process_stats #706

Closed
gnovv opened this issue Feb 23, 2022 · 0 comments · Fixed by #707
Closed

[Chore]: Write e2e tests for GET process_stats #706

gnovv opened this issue Feb 23, 2022 · 0 comments · Fixed by #707

Comments

@gnovv
Copy link
Contributor

gnovv commented Feb 23, 2022

Background

A part of #681 we extended the functionality of the process_stats endpoint. Since the endpoint already existed, we did not add an e2e test for it.

Additionally we noticed that the MetricsFetcher uses a privileged client. As a nice-to-have evaluate wether or not this can be changed to a userclient.

Action to take

Write an e2e test for the GET process stats happy path-initially without metrics server present.

Adding the metrics server is nice-to-have

Adding the user client is nice-to-have

Impact

This will make the tests around metrics server usage more robust, and ensure that we did not make any RBAC mistakes.

Dev Notes

No response

@gnovv gnovv added the chore label Feb 23, 2022
gnovv added a commit that referenced this issue Feb 24, 2022
#706

- Adds metrics-server to kind deployment script
- Pins kpack ClusterStore node buildpack version to previous working one
- Adds an e2e test for the GET process_stats endpoint when metrics server is present

Co-authored-by: Ashwin Krishna <krishnaas@vmware.com>
@gcapizzi gcapizzi moved this to ✅ Done in Korifi - Backlog Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants