Add unit tests #284
Merged
Add unit tests #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yavor16
force-pushed
the
add-unit-tests
branch
from
d901117
to
4337923
Compare
ikasarov
reviewed
Oct 14, 2024
| ParsingException expectedException = new ParsingException(resultException.getCause(), Messages.CANNOT_CONVERT_JSON_STREAM_TO_MAP, | ||
| errorMessage, invalidJsonInputStream); | ||
| Assertions.assertEquals(expectedException.getMessage(), resultException.getMessage()); | ||
| ParsingException expectedException = new ParsingException(resultException.getCause(), |
There was a problem hiding this comment.
maybe remove this exception construction and just add a check for equals(Messages.CANNOT...
as everything else seems to be taken from the exception we're checking anyway
There was a problem hiding this comment.
But the messages is different is not done this way.
| double testDouble = 45.67; | ||
| List<Object> originalList = Arrays.asList("String", testNumber, testDouble); | ||
|
|
||
| List<String> castedList = ListUtil.cast(originalList); |
There was a problem hiding this comment.
past tense of 'cast' is 'cast' 😄
| } | ||
|
|
||
| @Test | ||
| void testMergeSafely_withBothMapsNonNull() { |
There was a problem hiding this comment.
maybe add a the same key to both maps to check if it's overwritten correctly in this test.
Yavor16
force-pushed
the
add-unit-tests
branch
from
4337923
to
b7e7990
Compare
Yavor16
force-pushed
the
add-unit-tests
branch
from
b7e7990
to
b837f7b
Compare
|
ikasarov
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.