Allow specifying port and databases for bbr when not using bosh links

[rkoster]

Since bosh create-env still does not support using links, I would like to propose the following changes to the bbr job. To allow us to switch to the postgres bbr job, for bucc.

Original issue: #26

[cfdreddbot]

✅ Hey rkoster! The commit authors and yourself have already signed the CLA.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/162541460

The labels on this github issue will be updated when the story is started.

[valeriap]

@rkoster thank you very much for sending this PR.

We would like to support the feature, but unfortunately we cannot accept it as is because it is missing an acceptance test. It should verify that a co-located bbr-postgres-db job without a link present can successfully back up and restore a database.

[rkoster]

@valeriap have added a test, it compiles but I'm unable to run test in my current environment. Apparently the test suite does not support bosh with uaa auth...
Has CI for PR branches been enabled? Asking because not having to setup a new bosh environment would save me some time.

[valeriap]

@rkoster Thanks for updating the test suite.
The CI for PR is not enabled yet and we have a story in the backlog to support bosh with uaa.
I've run the suite with the PR and the following typo was found:

diff --git a/jobs/bbr-postgres-db/templates/config.sh.erb b/jobs/bbr-postgres-db/templates/config.sh.erb
index 3665c29..291ec52 100755
--- a/jobs/bbr-postgres-db/templates/config.sh.erb
+++ b/jobs/bbr-postgres-db/templates/config.sh.erb
@@ -18,7 +18,7 @@ if_link("database") do |data|
   end

   port = data.p("databases.port")
-  databases = data.p("databases.database")
+  databases = data.p("databases.databases")
 end

  %>

With this typo fixed the suite has run fine.

[rkoster]

Thanks, have fixed the typo