Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Dynatrace hook #149

Merged
merged 2 commits into from
Feb 10, 2020
Merged

added Dynatrace hook #149

merged 2 commits into from
Feb 10, 2020

Conversation

arthfl
Copy link
Contributor

@arthfl arthfl commented Nov 8, 2019

Thanks for contributing to the buildpack. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

Added a hook for the Dynatrace OneAgent-SDK agent, so it can be used in Python apps

  • An explanation of the use cases your change solves

CF users can utilize the OneAgent SDK in their Python apps

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have added an integration test

No integration test currently. Is this a hard requirement? If yes i can add one.

added libbuildpack-dynatrace to go.mod
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/169649879

The labels on this github issue will be updated when the story is started.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 8, 2019

CLA Check
The committers are authorized under a signed CLA.

@ryanmoran
Copy link
Contributor

@arthfl would you please add an integration test that confirms this works when pushing to CF? There is an existing example for the nodejs-buildpack here.

Thanks!

@arthfl
Copy link
Contributor Author

arthfl commented Jan 16, 2020

@ryanmoran
Thanks for checking, added the integration test just now.

FYI: the tests aren't working with go 1.13 anymore: golang/go#34443

@arthfl
Copy link
Contributor Author

arthfl commented Jan 29, 2020

Any ETA on this?

@ryanmoran ryanmoran merged commit 122692d into cloudfoundry:develop Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants