Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC for Security Group Filtering #18

Closed
wants to merge 1 commit into from
Closed

PoC for Security Group Filtering #18

wants to merge 1 commit into from

Conversation

Keyli0Iliev
Copy link

@Keyli0Iliev Keyli0Iliev commented Jan 13, 2023

Thank you for submitting a pull request to the route-emitter repository!

We appreciate the contribution. To help us understand the context for your pull request, please fill out this template to the best of your ability.

Please make sure to complete all of the following steps

  1. Check the Contributing document on how to sign the CLA and run tests.
  2. Submit your PR to this repo.
  3. Submit an accompanying PR Review Request referencing this PR so the Diego Team knows to review your pull request.

Please provide the following information:

What is this change about?

Enabling the Security group filtering from the route-emitter

What problem it is trying to solve?

Route-emitter doesn't need Security Groups to perform it's tasks, and in cases where security groups are sent it generates network load

What is the impact if the change is not made?

The route emitter will continue to receive large amounts of unnecessary data

How should this change be described in diego-release release notes?

Adding Security group filtering

Please provide any contextual information.

Diego-release Issue link
BBS PR link

Tag your pair, your PM, and/or team!

@PlamenDoychev

Thank you!

@Keyli0Iliev
Copy link
Author

[DoNotMerge]
[PoC]

@jrussett
Copy link
Contributor

I'm going to close this issue because the referenced issue has since been closed (see: cloudfoundry/diego-release#678 (comment)) and that I believe the desired changes were merged in: #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants