Be clear about the state of resources after a failure#541
Merged
mattmcneeney merged 1 commit intocloudfoundry:masterfrom Jul 12, 2018
Merged
Be clear about the state of resources after a failure#541mattmcneeney merged 1 commit intocloudfoundry:masterfrom
mattmcneeney merged 1 commit intocloudfoundry:masterfrom
Conversation
|
Hey duglin! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Contributor
|
@duglin Does this text make sense given that we use I agree with this text for all other 4xx and 5xx codes. |
Contributor
Author
|
I think a 410 is still ok with this text because its still "Gone" after the broker responded with a "410 Gone". Its still semantically in the same state. Right? |
Contributor
Author
|
Updates the text based on yesterday's meeting |
mattmcneeney
approved these changes
Jul 12, 2018
n3wscott
approved these changes
Jul 12, 2018
I'd like to keep the first MUST but if people are afraid that we can't due to it technically being a breaking spec change, then we can drop it down to a SHOULD. But since 4xx's are means to be error for "bad input" I figured brokers should catch these before any real processing on the resource happened. Signed-off-by: Doug Davis <dug@us.ibm.com>
n3wscott
approved these changes
Jul 12, 2018
mattmcneeney
approved these changes
Jul 12, 2018
zrob
approved these changes
Jul 12, 2018
fmui
approved these changes
Jul 12, 2018
duglin
pushed a commit
to duglin/servicebroker
that referenced
this pull request
Aug 14, 2018
Inconsistency introduced by: cloudfoundry#541 Fixes cloudfoundry#563 Signed-off-by: Doug Davis <dug@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to keep the first MUST but if people are afraid that we can't
due to it technically being a breaking spec change, then we can drop it
down to a SHOULD. But since 4xx's are means to be error for "bad input"
I figured brokers should catch these before any real processing on the
resource happened.
Signed-off-by: Doug Davis dug@us.ibm.com